Skip to content

Comments

fix: Error cleanups continued#2838

Merged
cijothomas merged 6 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/error-cleanups
Mar 21, 2025
Merged

fix: Error cleanups continued#2838
cijothomas merged 6 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/error-cleanups

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Mar 20, 2025 •
edited
Loading

Continuing from #2790 this actually closes #2561

Also additional cleanup done in InMemoryExporter to not use the to-be-removed-in-next-pr Error types.

@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.9%. Comparing base (36c48db) to head (a7de7b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/lib.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 2 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2838   +/-   ##
=====================================
  Coverage   80.8%   80.9%           
=====================================
  Files        124     124           
  Lines      23743   23726   -17     
=====================================
  Hits       19200   19200           
+ Misses      4543    4526   -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas marked this pull request as ready for review March 20, 2025 02:16
@cijothomas cijothomas requested a review from a team as a code owner March 20, 2025 02:16
scottgerring
scottgerring reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a good idea - there's not much value in propagating 1 million error variants back to a caller that ignores them - but I wonder if we shouldn't try and use Error trait impls in everything that returns errors for consistency and clarity?

@cijothomas
Copy link
Member Author

cijothomas commented Mar 20, 2025

Overall I think this is a good idea - there's not much value in propagating 1 million error variants back to a caller that ignores them - but I wonder if we shouldn't try and use Error trait impls in everything that returns errors for consistency and clarity?

done.

@cijothomas cijothomas merged commit 3e77a22 into open-telemetry:main Mar 21, 2025
22 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/error-cleanups branch March 21, 2025 18:42
takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
@cijothomas
fix: Error cleanups continued (open-telemetry#2838)
0d16568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottgerring scottgerring scottgerring left review comments

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should OTLP Exporter Error enum be public and visible to the processor?

3 participants

@cijothomas @scottgerring @lalitb